consul_exporter improvement for version 0.4.0 and above #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on the consul_exporter version being used
|
Thanks for this @RogierO! Could you add a tiny acceptance test that installs and old version and afterwards a new one? You can find some examples here: https://github.com/voxpupuli/puppet-prometheus/tree/master/spec/acceptance |
bastelfreak
reviewed
Oct 5, 2018
| describe 'prometheus consul exporter version 0.3.0' do | ||
| it ' consul_exporter installs with version 0.3.0' do | ||
| pp = "class {'prometheus::consul_exporter': version => '0.3.0' }" | ||
| apply_manifest(pp, catch_failures: true) |
There was a problem hiding this comment.
can you here and in line 24 add apply_manifest(pp, catch_changes: true)? We always need to test for idempotency
bastelfreak
reviewed
Oct 5, 2018
| @@ -1,4 +1,4 @@ | |||
| require 'spec_helper_acceptance' | |||
| #require 'spec_helper_acceptance' | |||
There was a problem hiding this comment.
can you explain why you did this?
bastelfreak
added
needs-work
|
@bastelfreak I've added the spec test for the consul_exporter, including the adjustments you've told me in the comment above. |
bastelfreak
reviewed
Oct 14, 2018
| apply_manifest(pp, catch_changes: true) | ||
| end | ||
| describe process('consul_exporter') do | ||
| its(:args) { is_expected.to match %r{\ --consul.server} } |
There was a problem hiding this comment.
ah nice, I haven't seen this test in a while. Good job!
|
Thanks! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
consul_exporter improvement for version 0.4.0 and above
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
consul_exporter improvement for version 0.4.0 and above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
With the release of version 0.4.0 of the consul exporter, the single dashes ( - ) has been changed to double dashes ( -- ).
( [CHANGE] Adopt standard Prometheus flags library (mostly double dashes)) #66
For the manifest consul_exporter.pp the following improvements have been made:
This Pull Request (PR) fixes the following issues
n/a