Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use this module on fresh alert manager instances #55

Closed
scottybrisbane opened this issue Sep 4, 2017 · 3 comments · Fixed by #101
Closed

Unable to use this module on fresh alert manager instances #55

scottybrisbane opened this issue Sep 4, 2017 · 3 comments · Fixed by #101
Labels
bug Something isn't working

Comments

@scottybrisbane
Copy link

In the alertmanager.pp manifests there is a service resource that instructs puppet to stop the alert_manager service if it is running, since the service has been renamed. This works fine on an old instance that has the alert_manager service, but breaks down on new instances that have no such service. I am seeing the following error on a fresh instance that attempts to start the alertmanager:

/Stage[main]/Prometheus::Alertmanager/Service[alert_manager]) Could not evaluate: Could not find init script or upstart conf file for 'alert_manager'

service { 'alert_manager':
ensure => 'stopped',
}

@skarip
Copy link

skarip commented Oct 19, 2017

seeing the same thing -- any planned fix?

@juniorsysadmin juniorsysadmin added the bug Something isn't working label Oct 19, 2017
@bastelfreak
Copy link
Member

Hi @scottybrisbane and @skarip, is one of you able to provide a patch for this?

@tuxmea
Copy link
Member

tuxmea commented Oct 25, 2017

Possible solution (please provide feedback):

  • providing a fact which checks whether alert_manager is running
  • make the service resource depending on fact result

tuxmea pushed a commit to tuxmea/puppet-prometheus that referenced this issue Nov 1, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this issue Aug 28, 2019
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this issue May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants