Rubocop auto fixes #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
commented
Dec 12, 2017
| @@ -77,7 +77,7 @@ def check_set | |||
| @resource.value(:action) == :set | |||
| end | |||
|
|
|||
| def permission=(value) | |||
| def permission=(_value) # TODO: Investigate why we're not using this parameter | |||
There was a problem hiding this comment.
This looked a bit fishy. I think rubocop is correct that value was not being used, but perhaps it should be? Dunno, hence the comment.
|
LGTM. Will review the |
dobbymoodge
added a commit
that referenced
this pull request
Dec 12, 2017
This reverts commit 7af3036.
|
Reopened in #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No manual fixes here, but lots of care taken to split the fixes into individual commits for easier review.
With each commit, no new violations are introduced.