Rubocop fixes #240
Merged
Rubocop fixes #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
The following cops are fixed in this commit. `Style/ClosingParenthesisIndentation` `Style/CaseIndentation` `Style/IndentationWidth` `Style/IndentationConsistency` Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Refactored `lib/puppet/provider/package/pear.rb` `latest` method to match `latest` in `lib/puppet/provider/package/pecl.rb`. Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
I've disabled the cop on the instances where `assignment in condition` seemed to make very good sense. Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
|
Make that 17. |
Signed-off-by: Alexander Fisher <[email protected]>
|
15 |
Signed-off-by: Alexander Fisher <[email protected]>
|
10 |
alexjfisher
commented
Sep 25, 2016
| @@ -94,7 +94,7 @@ def install(useversion = true) | |||
| end | |||
| end | |||
|
|
|||
| if pipe = @resource[:pipe] | |||
| if pipe == @resource[:pipe] | |||
There was a problem hiding this comment.
@bastelfreak Oops. This was clearly not right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was 76 violations, now 19.