Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config validate #85

Merged
merged 5 commits into from
May 1, 2023
Merged

Add config validate #85

merged 5 commits into from
May 1, 2023

Conversation

maxadamo
Copy link
Contributor

Pull Request (PR) description

Add config validate

This Pull Request (PR) fixes the following issues

Fixes #84

manifests/config.pp Outdated Show resolved Hide resolved
@maxadamo
Copy link
Contributor Author

maxadamo commented Apr 23, 2023

the CI looks good, but, apart from any other observation/objection, I want to test this change onto real servers, where I can try to uninstall ruby.

@maxadamo
Copy link
Contributor Author

maxadamo commented Apr 24, 2023

for the sake of sharing: I uninstalled ruby, I removed puppet from the PATH, I ran: /opt/puppetlabs/puppet/bin/puppet agent -t and it failed with this error:

Error: Execution of '/usr/local/bin/config_validate.rb /etc/nomad.d/config.json20230424-3227133-172987x' returned 127: /usr/bin/env: 'ruby': No such file or directory

It's good to have multiple options.

Copy link
Member

@jay7x jay7x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastelfreak bastelfreak added the enhancement New feature or request label May 1, 2023
@maxadamo maxadamo merged commit 7ab1246 into voxpupuli:master May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add config validate
3 participants