-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init.pp cleanup; bump nomand 1.0.1 -> 1.0.2 #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opins. moving to upstream service file structure
…_style type to better reflect the code present
bastelfreak
reviewed
Jan 17, 2021
manifests/init.pp
Outdated
@@ -35,6 +35,29 @@ | |||
# }, | |||
# } | |||
# | |||
# @example Install as package from the HashiCorp repositories | |||
# class { '::nomad': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: classes should not anymore be called via topscope:
Suggested change
# class { '::nomad': | |
# class { 'nomad': |
Service file cleanup
…_style type to better reflect the code present
bastelfreak
reviewed
Jan 17, 2021
bastelfreak
changed the title
Init.pp cleanup
Init.pp cleanup; bump nomand 1.0.1 -> 1.0.2
Jan 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
adding install as package example, bumping version to , changing init_style type to better reflect the code present
This Pull Request (PR) fixes the following issues
Fixes #34