fix requires for proxy config when on ubuntu #51 #70
Conversation
Proxy config fails on ubuntu when using the managed repo voxpupuli#51
|
Waiting for CLA signature by @wenlock @wenlock - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/ Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html |
|
cla updated |
|
CLA signed by all contributors. |
|
What use is the ability to set an http proxy (but not https-proxy), if registry is set to an https-based url by default ? BTW, nice taunt with the "report issues" url at puppetforge leading to a page, where you can't report issues. |
| @@ -99,13 +99,17 @@ | |||
| ensure => present, | |||
| require => Anchor['nodejs::repo'] | |||
| } | |||
| $npm_require = 'Package[npm]' | |||
| } else | |||
There was a problem hiding this comment.
this is not how we usually write if/else
generally, i'd use a selector here, even if @mhaskel disagrees with me.
There was a problem hiding this comment.
@igalic :sigh:
@wknapik Apologies on the report issues URL, that will be fixed with the next nodejs release. The correct location to report issues is https://tickets.puppetlabs.com/browse/MODULES
fix requires for proxy config when on ubuntu #51
|
Thanks for the contribution @wenlock |
Correct broken application of PR #70
fix requires for proxy config when on ubuntu voxpupuli#51
Proxy config fails on ubuntu when using the managed repo #51