Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian 10 support #406

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Add Debian 10 support #406

merged 1 commit into from
Oct 29, 2019

Conversation

wiebe
Copy link
Contributor

@wiebe wiebe commented Oct 22, 2019

Pull Request (PR) description

Adds support for Debian 10

This Pull Request (PR) fixes the following issues

#400

Signed-off-by: Wiebe Verweij <[email protected]>
Copy link
Member

@Dan33l Dan33l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wiebe thank you for the PR.
Can you have a look to failing tests ?
Please enable acceptance tests also.

@Dan33l Dan33l added needs-work not ready to merge just yet tests-fail labels Oct 29, 2019
@wiebe
Copy link
Contributor Author

wiebe commented Oct 29, 2019

The tests fail because of an issue outside of these commits/pull request. See ekohl's comment in #403

@wiebe
Copy link
Contributor Author

wiebe commented Oct 29, 2019

I'm not entirely sure how adding acceptance tests would work, add it to the travis yml config i guess but where does the node definition / BEAKER_setfile come from?

@ghoneycutt
Copy link
Member

The error is a syntax error not related to this pull request

@ghoneycutt ghoneycutt merged commit 8841f71 into voxpupuli:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work not ready to merge just yet tests-fail
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants