Ensure NPM secret keys are idempotent in global_config_entry #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jan 31, 2019
bastelfreak
reviewed
Jan 31, 2019
bastelfreak
added
bug
|
Thanks! |
Merged
aboks
added a commit
to aboks/puppet-nodejs
that referenced
this pull request
Mar 1, 2019
The fix in voxpupuli#386 fixes idempotence for secrets that contain characters (like '=') that cause NPM to quote them in npmrc. Secrets that end up unquoted in npmrc are not handled correctly however. This fix makes the quotes optional when checking if the config value is already set correctly.
juniorsysadmin
pushed a commit
that referenced
this pull request
Apr 9, 2019
* Fix idempotence of unquoted secrets The fix in #386 fixes idempotence for secrets that contain characters (like '=') that cause NPM to quote them in npmrc. Secrets that end up unquoted in npmrc are not handled correctly however. This fix makes the quotes optional when checking if the config value is already set correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Fixes #326