Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ubuntu bionic 18.04, #361 #362

Merged
merged 2 commits into from
Apr 29, 2018

Conversation

fnoop
Copy link
Contributor

@fnoop fnoop commented Apr 28, 2018

A tiny fix to support Ubuntu 18.04 LTS (Bionic Beaver)

@fnoop
Copy link
Contributor Author

fnoop commented Apr 28, 2018

Fixes #361

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Apr 28, 2018
@juniorsysadmin
Copy link
Member

Perhaps add a line to metadata.json as well?

@bastelfreak
Copy link
Member

@fnoop sadly we can't test this properly on Ubuntu 18.04 yet. Did you test this locally on a 18.04? If so. how did you call the module, with any parameters? If that's the case, could you contribute it to https://github.com/voxpupuli/puppet-nodejs/tree/master/examples ?

@fnoop
Copy link
Contributor Author

fnoop commented Apr 28, 2018

Yes tested locally on 18.04, works fine - it's literally a one character fix. The OS detection/support isn't very robust and will need to be changed for the next Ubuntu release, but works for 18.04.
No parameters, it will behave as before as with other OS.

@bastelfreak
Copy link
Member

voxpupuli/facterdb#82 (comment) spec tests should work soonish

@juniorsysadmin juniorsysadmin merged commit 2880fc4 into voxpupuli:master Apr 29, 2018
@mpdude
Copy link

mpdude commented May 28, 2018

Could you please release a 5.0.1 to include this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants