Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to install failure's on Ubuntu #34

Merged
merged 5 commits into from
Aug 1, 2013
Merged

Fix to install failure's on Ubuntu #34

merged 5 commits into from
Aug 1, 2013

Conversation

siwilkins
Copy link
Contributor

Hi.

As described here: https://chrislea.com/2013/03/15/upgrading-from-node-js-0-8-x-to-0-10-0-from-my-ppa/, the node.js package in Chris Lea's PPA now contains npm. Requiring npm separately causes Ubuntu to fallback to it's own packaged version, which requires an earlier version of node.js. This patch causes the npm package to not be required if using Chris's PPA.

@kimptoc
Copy link

kimptoc commented May 8, 2013

+1

1 similar comment
@carlhopf
Copy link

+1

@adepretis
Copy link

+1

nodejs-dev PPA for Ubuntu (Chris Lea) was missing
@salimane
Copy link

salimane commented Jun 3, 2013

+1

3 similar comments
@andyshinn
Copy link

👍

@BrainBacon
Copy link

+1

@ewnd9
Copy link

ewnd9 commented Aug 1, 2013

+1

@apenney
Copy link

apenney commented Aug 1, 2013

Any chance you can rebase this on master? I can't merge it despite all the +1's as it's got conflicts. :)

Rebase it and I'll get this sorted for you.

@siwilkins
Copy link
Contributor Author

I've now merged the pending changes back into mine, so hopefully it's good to merge back.

Cheers,
Si

apenney pushed a commit that referenced this pull request Aug 1, 2013
Fix to install failure's on Ubuntu
@apenney apenney merged commit 2fe3bcb into voxpupuli:master Aug 1, 2013
@apenney
Copy link

apenney commented Aug 1, 2013

And merged, hope that helps all you ubuntu users :)

@rtgibbons
Copy link

I think there is a issue with the logic $::operatingsystem != 'ubuntu' or $::lsbdistcodename == 'Precise' this will install the package if the OS Release is Precise, I need to not install it while on Precise

Switching it to $::operatingsystem != 'ubuntu' or $::lsbdistcodename != 'Precise' should be all that's needed

@zsalzbank
Copy link

@rtgibbons +1

@sambeckett
Copy link

amazon EC2 Ubuntu,
Just installed "Unpacking nodejs (from .../nodejs_0.10.17-1chl1raring1_amd64.deb) ..."
apt-get install npm
npm : Depends: nodejs (>= 0.6.19
dfsg1-3) but it is not going to be installed

@apenney
Copy link

apenney commented Aug 26, 2013

If you could all test #45 I would appreciate it (I don't use nodejs so I want to make sure I didn't bungle this for you all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.