Replace anchors with 'contain' #310
Conversation
manifests/init.pp
Outdated
| include $repo_class | ||
| anchor { '::nodejs::begin': } | ||
| -> Class[$repo_class] | ||
| contain $repo_class |
There was a problem hiding this comment.
Including it is better. Say a user has Class['::epel'] -> Class['::x'] -> Class['::nodejs'] then trying to ```contain ::epel`` here will lead to issues while it shouldn't be. If the installation is contained and you set the repo class as a dependency then you're set. We don't care where epel is (as long as it's before us) and we don't give a guarantee about it.
There was a problem hiding this comment.
What was the anchor class around it for before then? Is it not needed, even if we switch back to include?
There was a problem hiding this comment.
See if the version I just pushed looks better
There was a problem hiding this comment.
I think the previous implementation was incorrect and this is the correct one.
manifests/init.pp
Outdated
| @@ -33,10 +33,9 @@ | |||
| include '::nodejs::install' | |||
replace anchors with
contain