Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually remove gpg_key dependency. #253

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Conversation

MG2R
Copy link
Contributor

@MG2R MG2R commented Oct 20, 2016

The changelog for release 1.3.0 states that the gpg_key dependency is removed. This
should be reflected in metadata.json.

@MG2R
Copy link
Contributor Author

MG2R commented Oct 21, 2016

Hm. Build failure seems to be on some unrelated line. Unsure what to do here.

lib/puppet/provider/package/npm.rb:3:1: C: Metrics/BlockLength: Block has too many lines. [61/25] 

Puppet::Type.type(:package).provide :npm, parent: Puppet::Provider::Package do ...

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@bastelfreak
Copy link
Member

@MG2R there is an issue with the used email addr in your commit, it isn't associated with your github account. The rubocop should be disabled, there may be a typo in it, I will check.

The changelog for release 1.3.0 states that the gpg_key dependency is removed. This
should be reflected in metadata.json.
@MG2R
Copy link
Contributor Author

MG2R commented Oct 25, 2016

Thanks for the heads-up. Amended the commit to fix the author e-mail.

@bastelfreak
Copy link
Member

thanks!

@bastelfreak bastelfreak merged commit ec473fe into voxpupuli:master Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants