-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for release 2.0.0 #224
Conversation
|
||
### Maintenance | ||
|
||
- partial reformat of code for better readability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
official drop of ruby 1.8.7…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would bump the module to 2.0.0 because this is a breaking change. I added a note about ruby to the Maintenance
part.
When using current master (818f81e), I get these messages:
Any idea where this is coming from? |
Are you on ruby1.8? We don't support that anymore. |
Looks alright to me |
Rubocop. |
I started with the changelog. I'm not very familiar with nodejs, could someone please take a look if I missed anything? I didn't find anything that looks like a major change, so I propose 1.4.0 as the next version.