Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release 2.0.0 #224

Merged
merged 3 commits into from
May 22, 2016
Merged

Prepare for release 2.0.0 #224

merged 3 commits into from
May 22, 2016

Conversation

bastelfreak
Copy link
Member

I started with the changelog. I'm not very familiar with nodejs, could someone please take a look if I missed anything? I didn't find anything that looks like a major change, so I propose 1.4.0 as the next version.


### Maintenance

- partial reformat of code for better readability
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

official drop of ruby 1.8.7…

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would bump the module to 2.0.0 because this is a breaking change. I added a note about ruby to the Maintenance part.

@bjoernhaeuser
Copy link

When using current master (818f81e), I get these messages:

# puppet agent --test
Notice: Ignoring --listen on onetime run
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Could not autoload puppet/provider/package/npm: /var/lib/puppet/lib/puppet/provider/package/npm.rb:3: syntax error, unexpected ':', expecting $end
...package).provide :npm, parent: Puppet::Provider::Package do
                              ^
Error: Could not retrieve local facts: Could not autoload puppet/provider/package/npm: /var/lib/puppet/lib/puppet/provider/package/npm.rb:3: syntax error, unexpected ':', expecting $end
...package).provide :npm, parent: Puppet::Provider::Package do
                              ^
Error: Failed to apply catalog: Could not retrieve local facts: Could not autoload puppet/provider/package/npm: /var/lib/puppet/lib/puppet/provider/package/npm.rb:3: syntax error, unexpected ':', expecting $end
...package).provide :npm, parent: Puppet::Provider::Package do
                              ^

Any idea where this is coming from?

@bastelfreak
Copy link
Member Author

Are you on ruby1.8? We don't support that anymore.

@juniorsysadmin
Copy link
Member

Looks alright to me

@jyaworski
Copy link
Member

Rubocop.

@bastelfreak bastelfreak changed the title [wip] prepare release prepare release May 22, 2016
@juniorsysadmin juniorsysadmin changed the title prepare release Prepare for release 2.0.0 May 22, 2016
@juniorsysadmin juniorsysadmin merged commit a20b0b4 into master May 22, 2016
@bastelfreak bastelfreak deleted the release branch May 22, 2016 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants