Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #202 - Implement a feature check for npm #203

Merged
merged 1 commit into from
Feb 28, 2016

Conversation

imriz
Copy link
Contributor

@imriz imriz commented Feb 28, 2016

No description provided.

@jyaworski
Copy link
Member

Can you give a description of the use-case for this?

@imriz
Copy link
Contributor Author

imriz commented Feb 28, 2016

Sure - When npm is being installed within the same catalog. This defers the use of the provider until the npm command becomes available, without requiring the user to explicitly set a dependency (i.e. require => Package['npm'] or require => Class['nodejs']).

See https://docs.puppetlabs.com/guides/provider_development.html#suitability

@jyaworski
Copy link
Member

Neat. Thanks for the contribution.

jyaworski added a commit that referenced this pull request Feb 28, 2016
Fixes #202 - Implement a feature check for npm
@jyaworski jyaworski merged commit 1338e79 into voxpupuli:master Feb 28, 2016
@petems
Copy link
Member

petems commented Feb 28, 2016

Awesome! 😄

@imriz
Copy link
Contributor Author

imriz commented Feb 28, 2016

Unfortunately, there is a small issue with it.
I opened a bug report with puppetlabs on it (https://tickets.puppetlabs.com/browse/PUP-5985), but I have a workaround for which I will open another PR tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants