Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure apt-get update is executed before installing packages #201

Merged
merged 1 commit into from
Feb 4, 2016

Conversation

saz
Copy link
Contributor

@saz saz commented Feb 4, 2016

If you're using the nodesource repo, nodejs will be installed before apt-get update is run. This will result in the wrong version of nodejs.

@bastelfreak
Copy link
Member

👍

bastelfreak added a commit that referenced this pull request Feb 4, 2016
ensure apt-get update is executed before installing packages
@bastelfreak bastelfreak merged commit 39a910d into voxpupuli:master Feb 4, 2016
@juniorsysadmin
Copy link
Member

Doesn't this depend on the update frequency hash? https://github.com/puppetlabs/puppetlabs-apt#class-apt

@saz
Copy link
Contributor Author

saz commented Feb 4, 2016

The mentioned frequency is only for configuring a run of apt-get update on each run (always), daily or weekly. This does not ensure, that apt-get update is executed, if a new source is added. This might happen by coincidence. And I don't see a reason to run an update with every puppet run. But even with the frequency set to always the module might install the wrong nodejs version, which might be fixed on the next run.

Via Boxer senden

Am 04.02.2016 12:24 nachm. schrieb Ben S [email protected]:

Doesn't this depend on the update frequency hash? https://github.com/puppetlabs/puppetlabs-apt#class-apt


Reply to this email directly or view it on GitHub.

@saz
Copy link
Contributor Author

saz commented Feb 4, 2016

Is there any roadmap for a new release? I'm able to stick with the current version from github, but don't want to miss the new release to change it back to a forge version.

@saz
Copy link
Contributor Author

saz commented Feb 4, 2016

This PR does also resolve #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants