Making it possible to provide concrete nodejs versions to force upgrade/downgrade (#197)

[fstr]

This fixes issue #197

It is now possible to upgrade/downgrade in Debian providing (forcing) a certain version. It's also possible to use 'latest', but using latest will not downgrade your version if you want to.

upgrade

class { 'nodejs':
  manage_package_repo => true,
  repo_url_suffix => '5.x',
  nodejs_package_ensure => 'latest'
}

upgrade

class { 'nodejs':
  manage_package_repo => true,
  repo_url_suffix => '5.x',
  nodejs_package_ensure => '5.4.0-1nodesource1~wheezy1'
}

downgrade

class { 'nodejs':
  manage_package_repo => true,
  repo_url_suffix => '4.x',
  nodejs_package_ensure => '4.2.4-1nodesource1~wheezy1'
}

[fstr]

I tried executing the existing tests with bundle exec rspec

/Library/Ruby/Gems/2.0.0/gems/puppet-3.8.4/lib/hiera/scope.rb:1:in `<top (required)>': Hiera is not a class (TypeError)
    from /Library/Ruby/Gems/2.0.0/gems/puppet-3.8.4/lib/puppet/indirector/hiera.rb:2:in `require'
    from /Library/Ruby/Gems/2.0.0/gems/puppet-3.8.4/lib/puppet/indirector/hiera.rb:2:in `<top (required)>'
    from /Library/Ruby/Gems/2.0.0/gems/puppet-3.8.4/lib/puppet/indirector/data_binding/hiera.rb:1:in `require'
    from /Library/Ruby/Gems/2.0.0/gems/puppet-3.8.4/lib/puppet/indirector/data_binding/hiera.rb:1:in `<top (required)>'
    from /Library/Ruby/Gems/2.0.0/gems/puppet-3.8.4/lib/puppet/test/test_helper.rb:1:in `require'
    from /Library/Ruby/Gems/2.0.0/gems/puppet-3.8.4/lib/puppet/test/test_helper.rb:1:in `<top (required)>'
    from /Users/florian/.bundler/ruby/2.0.0/rspec-puppet-7ab588ecdd1e/lib/rspec-puppet.rb:12:in `require'
    from /Users/florian/.bundler/ruby/2.0.0/rspec-puppet-7ab588ecdd1e/lib/rspec-puppet.rb:12:in `<top (required)>'
    from /Library/Ruby/Gems/2.0.0/gems/puppetlabs_spec_helper-1.0.1/lib/puppetlabs_spec_helper/module_spec_helper.rb:1:in `require'
    from /Library/Ruby/Gems/2.0.0/gems/puppetlabs_spec_helper-1.0.1/lib/puppetlabs_spec_helper/module_spec_helper.rb:1:in `<top (required)>'
    from /Users/florian/puppet-nodejs/spec/spec_helper.rb:1:in `require'
    from /Users/florian/puppet-nodejs/spec/spec_helper.rb:1:in `<top (required)>'
    from /Users/florian/puppet-nodejs/spec/classes/nodejs_spec.rb:1:in `require'
    from /Users/florian/puppet-nodejs/spec/classes/nodejs_spec.rb:1:in `<top (required)>'
    from /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.4.1/lib/rspec/core/configuration.rb:1361:in `load'
    from /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.4.1/lib/rspec/core/configuration.rb:1361:in `block in load_spec_files'
    from /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.4.1/lib/rspec/core/configuration.rb:1359:in `each'
    from /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.4.1/lib/rspec/core/configuration.rb:1359:in `load_spec_files'
    from /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.4.1/lib/rspec/core/runner.rb:102:in `setup'
    from /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.4.1/lib/rspec/core/runner.rb:88:in `run'
    from /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.4.1/lib/rspec/core/runner.rb:73:in `run'
    from /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.4.1/lib/rspec/core/runner.rb:41:in `invoke'
    from /Library/Ruby/Gems/2.0.0/gems/rspec-core-3.4.1/exe/rspec:4:in `<top (required)>'
    from /usr/local/bin/rspec:23:in `load'
    from /usr/local/bin/rspec:23:in `<main>'

This error seems unrelated to my patch though (imo).
OSX 10.11.2
VirtualBox 5.0.10

I am not that experienced in Ruby/Puppet so I don't really know how to solve it.

[rnelson0]

@fstr You want to run bundle exec rake test, or bundle exec rake -T to see the individual tasks to run (like syntax or rubocop).

[juniorsysadmin]

What's wrong with just having the change: ($ensure != 'absent') ?
There are other operating system families using this module other Debian ones, so we can't just sprinkle apt-update references everywhere.
Perhaps the root cause of downgrades not working even when the repo_url_suffix and nodejs_package_ensure is changed is the value of the apt update frequency (https://github.com/puppetlabs/puppetlabs-apt#update-the-list-of-packages), no?

[fstr]

I have my update frequency on always. I investigated this problem again and you are right.

The apt-get update call is not needed.

The install failed because the nodesource repository updated from 5.4.0-1nodesource1~wheezy1 to 5.4.1-1nodesource1~wheezy1 while I was working on the module. Since they always only keep one version in the repository, but I used a fixed version, it suddenly didn't work anymore.

So for upgrading it would be:

class { 'nodejs':
  manage_package_repo => true,
  repo_url_suffix => '5.x',
  nodejs_package_ensure => 'latest'
}

For downgrading it would be:

class { 'nodejs':
  manage_package_repo => true,
  repo_url_suffix => '4.x',
  nodejs_package_ensure => '4.2.4-1nodesource1~wheezy1' # get the version from the repository URL (latest or present doesn't work here when downgrading)
}

I will remove the commit with the apt-get update changes later.

[juniorsysadmin]

@fstr Ready to merge?

[fstr]

yes