Change npm_package_name from "undef" to "false" for better comparison.

[x3dfxjunkie]

Fixes #160

Before:

# puppet apply -v  -e 'class { "nodejs": npm_package_name => undef,} package { "npm": ensure => "2.14.14", provider => "npm",}'
Info: Loading facts
Info: Loading facts
Error: Duplicate declaration: Package[npm] is already declared in file /etc/puppet/modules/nodejs/manifests/install.pp:52; cannot redeclare at line 1 on node ***
Error: Duplicate declaration: Package[npm] is already declared in file /etc/puppet/modules/nodejs/manifests/install.pp:52; cannot redeclare at line 1 on node ***

After:

# puppet apply -v  -e 'class { "nodejs": npm_package_name => false,} package { "npm": ensure => "2.14.14", provider => "npm",}'
Info: Loading facts
Info: Loading facts
Notice: Compiled catalog for *** in environment production in 0.31 seconds
Info: Applying configuration version '1452278934'
Notice: /Stage[main]/Main/Package[npm]/ensure: ensure changed '1.4.29' to '2.14.14'
Notice: Finished catalog run in 4.97 seconds

[igalic]

mmhm. this makes sense.
@x3dfxjunkie would you mind doing a proper rebase (rather than that upstream merge)

---

n.b.: this would've been easier (or rather: less confusing) if you had used the github flow work flow.
see also voxpupuli/puppet-jira#99 (comment) for a step by step how to

[juniorsysadmin]

Hmmm. I'm a bit uncomfortable mixing strings and booleans in the same variable. Also, given undef evaluates to false, and therefore we don't manage the package, why are we getting duplicate declarations?

[x3dfxjunkie]

At least with puppet 3.x, undef isn't the same as false. That may be more of a bug with puppet, but not sure. I could change it to a proper string (like blank or none), but that seems less intuitive.

[x3dfxjunkie]

Rebased the merge out, sorry for that.

[igalic]

thank you @x3dfxjunkie!