Make repo::nodesource::apt compatible with puppetlabs-apt 2.x only #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing with STRICT_VARIABLES=yes, possibly due to the ::puppetversion fact in the puppetlabs-apt |
juniorsysadmin
force-pushed
the
apt-2x-fixes
branch
from
274d15f to
73b20b2
Compare
|
Rebased. TravisCI checks seem to all be okay now. |
juniorsysadmin
force-pushed
the
apt-2x-fixes
branch
from
73b20b2 to
6e4b93d
Compare
juniorsysadmin
force-pushed
the
apt-2x-fixes
branch
from
6e4b93d to
70060bc
Compare
juniorsysadmin
force-pushed
the
apt-2x-fixes
branch
from
70060bc to
2521739
Compare
|
@jmcclell RSpec test descriptions have now been fixed |
|
👍 |
juniorsysadmin
added a commit
that referenced
this pull request
Jun 20, 2015
Make repo::nodesource::apt compatible with puppetlabs-apt 2.x only
cegeka-jenkins
pushed a commit
to cegeka/puppet-nodejs
that referenced
this pull request
Oct 23, 2017
Make repo::nodesource::apt compatible with puppetlabs-apt 2.x only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An equivalent PR for this has already been started in #129 - this PR just adds some more bits and pieces. It is probably preferred that this get merged AFTER the next release (see #126 )