Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gpg key checking warings after f588f26 in puppetlabs-apt #119

Merged
merged 1 commit into from
Apr 23, 2015
Merged

Fix gpg key checking warings after f588f26 in puppetlabs-apt #119

merged 1 commit into from
Apr 23, 2015

Conversation

paroga
Copy link
Contributor

@paroga paroga commented Mar 17, 2015

Use the full fingerprint for the apt key to silence the warning.

@paroga
Fix gpg key checking warings after f588f26 in puppetlabs-apt
e1c544a 
Use the full fingerprint for the apt key to silence the warning.
@juniorsysadmin
Copy link
Member

Failing tests should pass when PR #120 is merged

@geerteltink
Copy link

I have tried this fix and it breaks npm installation (vagrant with ubuntu/trusty64). When installing npm modules it throws: "Error: Command npm is missing".
Reverting to the short key installed npm and the modules, but gave the warning again obviously.

@juniorsysadmin
Copy link
Member

@xtreamwayz
Verified as failing on puppetlabs/ubuntu-14.04-64-nocm 1.00 with puppetlabs-apt (v1.8.0) using Puppet 3.7.4. The problem appears to be related to dependency ordering and not specifically this PR though. (You're seeing this error because the native nodejs package got installed instead, which doesn't include npm)

@juniorsysadmin
Copy link
Member

@xtreamwayz The class containment issue should hopefully be fixed in #121

@juniorsysadmin juniorsysadmin mentioned this pull request Mar 21, 2015
Closed
underscorgan pushed a commit that referenced this pull request Apr 23, 2015
Merge pull request #119 from paroga/gpg_key
4ab65c3 
Fix gpg key checking warings after f588f26 in puppetlabs-apt
@underscorgan underscorgan merged commit 4ab65c3 into voxpupuli:master Apr 23, 2015
@underscorgan
Copy link
Contributor

Thanks @paroga !

@paroga paroga deleted the gpg_key branch April 23, 2015 17:40
cegeka-jenkins pushed a commit to cegeka/puppet-nodejs that referenced this pull request Oct 23, 2017
Merge pull request voxpupuli#119 from paroga/gpg_key
7318260 
Fix gpg key checking warings after f588f26 in puppetlabs-apt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paroga @juniorsysadmin @geerteltink @underscorgan