Add max_nesting parameter to npm list json parse #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Json parsing faild due to too deep nesting, and this made the install check fail. This caused the packages to be reinstalled on each run. Hard coded to 100 ==> default: Debug: Executing '/usr/bin/npm list --json --global' ==> default: Debug: Error: npm list --json command error nesting of 20 is too deep ==> default: Debug: Executing '/usr/bin/npm install --global bower'
|
Note that #78 will need similar change to not fail at the 'latest' function |
|
+1 |
underscorgan
pushed a commit
that referenced
this pull request
Jan 21, 2015
Add max_nesting parameter to npm list json parse
|
Great, thanks @rangoy ! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nodejs
that referenced
this pull request
Oct 23, 2017
Add max_nesting parameter to npm list json parse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Json parsing faild due to too deep nesting, and this made the install check fail. This caused the packages to be reinstalled on each run.
Hard coded to 100
==> default: Debug: Executing '/usr/bin/npm list --json --global'
==> default: Debug: Error: npm list --json command error nesting of 20 is too deep
==> default: Debug: Executing '/usr/bin/npm install --global bower'