Rename v[hH]ost to server everywhere #980
Conversation
|
This looks good to me, can you just tidy up the rest of the hashrocket and = alignment, and then I'll merge? Let's also try to not merge anything else until this gets merged so we don't have to redo it again. @3flex: I totally agree that your way is a bit more elegant, unfortunately, I don't have the time / energy to implement it properly, however, if someone wants to pick up that torch, I'd be happy to wait on the next release until we can rework this to use your model. |
sacres
force-pushed
the
vhost_server_migration
branch
from
829a080 to
4ce5472
Compare
| } else { | ||
| $content_real = template('nginx/server/locations/empty.erb') | ||
| } | ||
|
|
There was a problem hiding this comment.
This block shouldn't have been added back. I think you'll have to do the search/replace on the latest code from master.
| @@ -261,9 +259,6 @@ | |||
| if ($fastcgi_split_path != undef) { | |||
| validate_string($fastcgi_split_path) | |||
| } | |||
| if ($fastcgi_index != undef) { | |||
| validate_string($fastcgi_index) | |||
| } | |||
Lint fixes. Formatting Replace stale code and re-format
sacres
force-pushed
the
vhost_server_migration
branch
from
4ce5472 to
4b8c57f
Compare
|
@3flex good catch on that other stuff. |
|
Common people. Breaking changes are major bumps. Not minor. Read semver.org. |
|
Aside from the fact that this was merged and released years ago (https://github.com/voxpupuli/puppet-nginx/blob/master/CHANGELOG.md#v060-2017-01-13): https://semver.org/#spec-item-4
|
Breaking change: rename v[hH]ost to server everywhere
Replaces PR: #968 This addresses rebase/sed and [vV]host as well as linting.