fix validation range for location priority #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like ssl priority adds 300, which might be why it's 899, not 599? https://github.com/voxpupuli/puppet-nginx/blob/master/manifests/resource/location.pp#L436 |
|
Seems to jive with the docs. I think we should land this. Just be aware a few users might show up with 'it used to work ARGH' I think we're fixing a bug here, not making a backwards incompat change |
|
@nibalizer Yeah, sorry, two unrelated questions. This PR is not backwards-incompatible, just was asking for general feedback about if it looked sane. I think this is the right behavior. |
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
…iority fix validation range for location priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #971
Fix the validation range for location's "priority" attribute to match docs. Using a higher value seems to cause unpredictable behavior.