Restore $service_restart, now defaulting to undefined, but now withou… #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r (see comments in #921). Pass on $nginx::service_foo directly to service class
|
per @hunner, seems like it's a better practice to just pull the necessary params in the way I'm changing it to, since |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
…start Restore $service_restart, now defaulting to undefined, but now withou…
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
…start Restore $service_restart, now defaulting to undefined, but now withou…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now defaulting to undef, but without checking whether now removed $configtest_enable param exists. This allows users to set a custom restart command if just changing the service name isn't enough. See comments in #921
I'm still wondering if we should invoke nginx::service differently from how it is now:
https://github.com/voxpupuli/puppet-nginx/blob/master/manifests/init.pp#L305
and just set
$nginx::service::footo$nginx::foo; seems to me this would be a bit easier to parse.