Changes mock from mocha to rspec-mock #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rspec-mock generally advised over mocha these days as most of the previous killer features of mocha have been added to rspec-mock * Puppet are looking to move from mocha to rspec-mock (https://tickets.puppetlabs.com/browse/MODULES-3958) * Allows testing on 2.3.1 without having to pin Gems
petems
force-pushed
the
switch_to_rspec_mocks
branch
from
84345bc to
2a790a5
Compare
petems
changed the title
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Changes mock from mocha to rspec-mock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way of solving #917: don't use mocha at all