Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
US-CERT VU#797896 (and others) describes an attack where an end-user is capable of overriding the proxy setting for multiple FastCGI backends.
I propose we help mitigate this attack by removing the variable before reaching the backend as proposed by multiple vendors and industry players.
Sources:
https://www.kb.cert.org/vuls/id/797896
https://httpoxy.org/
https://www.nginx.com/blog/mitigating-the-httpoxy-vulnerability-with-nginx/
Relevant CVEs:
CVE-2016-5385: PHP
CVE-2016-5386: Go
CVE-2016-5387: Apache HTTP Server
CVE-2016-5388: Apache Tomcat
CVE-2016-1000109: HHVM
CVE-2016-1000110: Python