Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #822

Merged
merged 6 commits into from
Jun 23, 2016
Merged

Fix tests #822

merged 6 commits into from
Jun 23, 2016

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Jun 23, 2016

No description provided.

3flex added 6 commits June 22, 2016 21:06
We have some failing tests, and in the Puppet Style Guide it's a SHOULD, not a MUST that lines be under this length
Two reasons:
1. Newer is better!
2. Running lint < 2.0 with the current Rakefile will fail - lines longer than 80 chars will cause warnings, and Rakefile says to fail on warnings
* Moves beaker dependencies to system_tests group
* pin puppetlabs_spec_helper and rspec-puppet to compatible versions, which should minimize future breakage
* removed explicit dependency on rake
@3flex 3flex merged commit a4cee01 into master Jun 23, 2016
@3flex 3flex deleted the fix-tests branch June 23, 2016 03:04
slm0n87 pushed a commit to slm0n87/puppet-nginx that referenced this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant