Add ssl_session_tickets and ssl_session_ticket_key parameters #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -206,6 +210,8 @@ | |||
| $ssl_stapling_responder = undef, | |||
| $ssl_stapling_verify = false, | |||
| $ssl_session_timeout = '5m', | |||
| $ssl_session_tickets = 'on', | |||
There was a problem hiding this comment.
This should default undef, and be conditional in the template.
Since it was introduced in 1.5.9, and some distros support older versions than that, this directive would be unrecognized by nginx and prevent it from starting.
There was a problem hiding this comment.
Rebased with suggested default.
slm0n87
pushed a commit
to slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
Add ssl_session_tickets and ssl_session_ticket_key parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for http://nginx.org/en/docs/http/ngx_http_ssl_module.html#ssl_session_tickets