I think this is what you meant in issue 62

[wolfspyre]

#62
I refactored all the variables to be topscope parameters defaulting to params::xxx

I cannot get the unit test suite you have setup working, but if you ping me on #puppet, or send me an email, once we get on the same page, I'll write a full suite of tests for rhel variants.

[jfryman]

@wolfspyre awesome! thanks for taking a stab at this. This is similar to what I was aiming for, and since I didn't really put any description on the issue other than a reminder for me...

There are a few things I want to keep in mind with a refactor here. The first is the interface. There are quite a few folks using this module as-is right now, and I haven't done a great job at keeping up with version numbers. So, a major refactor like this will get us into the realm of Semantic Versioning to allow users to lock at stable versions.

Secondly, I want to be able to use a new pattern that I've been working on to set defaults and allow a user to only selectively overwrite configuration parameters as necessary. Something like....

# init.pp
class nginx(
  $options = $nginx::params::defaults,
) { 
  include stdlib
  validate_hash($options) 

  $config_options = merge($nginx::params::defaults, $options)
...
}

# params.pp
class nginx::defaults {
  $defaults = {
    ...
  }
}

Basically, these parameter lists are getting a little unwieldy, and all for one-off uses. I'd like to minimize this all together.

[jfryman]

Way old. Thanks for taking a pass at this... going to revisit when 🕐 allows.