Convert $priority to integer before comparison #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparison was causing an error with parser = future and stringify_facts = false. This ensures that the comparison is done between two integers
|
Very nice. Thank you for the code! |
jfryman
added a commit
that referenced
this pull request
Oct 2, 2015
Convert $priority to integer before comparison
|
Thanks for merging this in but we were looking in our code and found that we were mistakenly setting this value to an string. The code I added will still work but I think it is unnecessary. |
maxenced
added a commit
to maxenced/puppet-nginx
that referenced
this pull request
Jul 19, 2016
slm0n87
pushed a commit
to slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
Convert $priority to integer before comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparison was causing an error with parser = future and stringify_facts = false. This ensures that the comparison is done between two integers
Fixes: #684