iterate server_name when rewrite_www_to_non_www is used

[kronos-pbrideau]

Was not working when server_name was an array

with

server_name            => [ 'a.example.com', 'b.example.org' ],
rewrite_www_to_non_www => true,

Before patch:

server {
  [...]
  server_name www.a.example.com;
  return 301 http://a.example.com$request_uri; 
}
[...]
server {
  [...]
  servername a.example.com
  [...]
}

now:

server {
  [...]
  server_name www.a.example.com;
  return 301 http://a.example.com$request_uri; 
}
server {
  [...]
  server_name www.b.example.org;
  return 301 http://b.example.org$request_uri; 
}

[...]
server {
  [...]
  servername a.example.com b.example.org
  [...]
}

[kronos-pbrideau]

Was it intended to show only the first server of the list? The comment in the tests suggest it is intended, but I don't understand the reason...

in the spec file:
should set the server_name of the rewrite server stanza to the first server_name with 'www.' stripped"

I don't seem to be the only one to detect this bug though: #381

@kalmanolah beeing the one who submit PR #310 do you see something bad about my PR?

[kalmanolah]

@kronos-pbrideau The PR looks alright to me. How I missed/ignored the fact that only the first server name was being handled is still a mystery to me. Thanks for the fix 👍

[3flex]

@kalmanolah thanks for reviewing!