Ensure isn't being respected on location. #676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @kwolf, the change makes sense. Can you please squash this to one commit? Thanks! Once done I'll merge. |
for some reason using ensure_real here breaks two tests.
Improvement to non-hiera usage example. * Fixed potention dependendy-cicle issue with example.
Improved wording on non-hiera example.
Currently there is no way to ensure => absent. I'm using these with stored configs to have servers register the member only, not the upstream. Removing them in a mis-configured incident is a bit of a burden without ensure => absent. Tests are passing under Ruby 2.1
for some reason using ensure_real here breaks two tests.
Comparison was causing an error with parser = future and stringify_facts = false. This ensures that the comparison is done between two integers
This should make the link to the QuickStart pull request ready.
|
I missed up squishing my commits. I'm going to close this and open another PR. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the ensure => absent PR I submitted last week. Locations support ensure, but it wasn't respected.
Tests passing in Ruby 2.1.2. I'd be glad to change this and resubmit if I've missed something.