Don't qualified call to defined resource type #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this is an valid improvement (over non qualification). My main motivation comes from the fact that it is not currently supported so well by "language-puppet".
|
Thanks, and my mistake for doing this in the first place as resource names are not limited by scope so as you say, don't need to be fully qualified in this manner. |
3flex
added a commit
that referenced
this pull request
Aug 10, 2015
Don't qualified call to defined resource type
PierreR
added a commit
to PierreR/puppetlabs-apache
that referenced
this pull request
Aug 26, 2015
According to best practices: (https://docs.puppetlabs.com/puppet/latest/reference/lang_defined_types.html#resource-uniqueness) See these accepted PRs: - theforeman/puppet-foreman#346 - voxpupuli/puppet-nginx#666
slm0n87
pushed a commit
to slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
Don't qualified call to defined resource type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is such an improvement (over non qualification).
My main motivation comes from the fact that it is not currently supported so well by "language-puppet".