Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple proxy_cache_path entries #637

Merged
merged 7 commits into from
Nov 30, 2015
Merged

Multiple proxy_cache_path entries #637

merged 7 commits into from
Nov 30, 2015

Conversation

jacobmw
Copy link
Contributor

@jacobmw jacobmw commented Jun 2, 2015

Adding ability to specify multiple proxy_cache_path entries with unique proxy_cache_keys_zone values

@3flex
Copy link
Contributor

3flex commented Jun 2, 2015

Couple of things:

  • Please add tests
  • Please build this capability into the existing proxy_cache_path parameter then populate the template using the new code after checking if the value is_a?(Hash), and using the existing code if it's not.

@3flex 3flex added the enhancement New feature or request label Jun 2, 2015
3flex and others added 3 commits June 3, 2015 14:44
…n a location resource

Adding spec tests for proxy_cache_key and proxy_cache_use_stale
…on for either

has or string for proxy_cache_path

made the conditional test to use is_a?(Hash) for simplicity's sake in
templates/conf.d/nginx.conf.erb
@jacobmw
Copy link
Contributor Author

jacobmw commented Jun 3, 2015

Rebuilt this capability into the existing proxy_cache_path parameter and added proper validation.

@pashamesh
Copy link

Why this pull request not merged yet?

@jfryman
Copy link
Contributor

jfryman commented Nov 30, 2015

@pashamesh why? because you haven't asked yet. :)

jfryman added a commit that referenced this pull request Nov 30, 2015
Multiple proxy_cache_path entries
@jfryman jfryman merged commit 0e930e9 into voxpupuli:master Nov 30, 2015
@pashamesh
Copy link

Thanks a lot :)

@jacobmw
Copy link
Contributor Author

jacobmw commented Nov 30, 2015

Wow, thanks, forgot all about this one. I guess now I can go point my Puppetfile back at this repo :)

cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Oct 23, 2017
slm0n87 pushed a commit to slm0n87/puppet-nginx that referenced this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants