Vhost and loation proxy_cache_key and proxy_cache_use_stale #636
Conversation
| @@ -66,6 +66,7 @@ | |||
| $proxy_buffers = '32 4k', | |||
| $proxy_buffer_size = '8k', | |||
| $proxy_cache_inactive = '20m', | |||
| $proxy_cache_key = '$scheme$proxy_host$request_uri', | |||
There was a problem hiding this comment.
I'm not seeing where this is referenced from... can it be removed?
There was a problem hiding this comment.
$scheme$proxy_host$request_uri is the actual default value:
http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_cache_key
There was a problem hiding this comment.
Yep, but the nginx::config::proxy_cache_key parameter you created here isn't referenced anywhere else.
|
Apart from my comment, looks good. Can you address that feedback, then squash the submission down to one commit? Then we can get it merged. If you're not sure how to do this, there's a useful guide here: https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history |
…n a location resource Adding spec tests for proxy_cache_key and proxy_cache_use_stale
|
I see what you mean about the proxy_cache_key. I've removed it and attempted to squash my submission. Please let me know if there's anything else I need to do. |
Vhost and loation proxy_cache_key and proxy_cache_use_stale
Vhost and loation proxy_cache_key and proxy_cache_use_stale
Vhost and loation proxy_cache_key and proxy_cache_use_stale
No description provided.