Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

location: make auth_basic_user_file resource unique #603

Closed
wants to merge 1 commit into from
Closed

location: make auth_basic_user_file resource unique #603

wants to merge 1 commit into from

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Apr 13, 2015

Before this change there would be conflicts if multiple vhosts contained locations with the
same name, and those locations set auth_basic_user_file.

Fixes #572

@3flex 3flex changed the title location: make auth_basic_user_file resource unique [WIP] location: make auth_basic_user_file resource unique Apr 13, 2015
@3flex 3flex mentioned this pull request Apr 13, 2015
Closed
@3flex
location: make auth_basic_user_file resource unique
08ea0de 
Before this change there would be conflicts if multiple vhosts contained locations with the
same name, and those locations set auth_basic_user_file
@3flex 3flex changed the title [WIP] location: make auth_basic_user_file resource unique location: make auth_basic_user_file resource unique Apr 14, 2015
@3flex
Copy link
Contributor Author

3flex commented Apr 14, 2015

Closing, as this is the wrong approach.

Currently the module copies the file to "${::nginx::config::conf_dir}/${location_sanitized}_htpasswd", but the template references the original file location. So the code being updated currently creates a new file then does nothing with it.

New PR will stop creating that file in the first place.

@3flex 3flex closed this Apr 14, 2015
@3flex 3flex deleted the 572-make-auth_basic_user_file-resource-name-unique branch April 14, 2015 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't have more than 1 password protected location
1 participant
@3flex