create a location #596
Closed
create a location #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You should be able to create a location when $try_files is not empty
|
@vladpanainte: are you willing / able to add tests for this? Obviously, it's been quite some time, but we need to either have the tests added (and the code rebased against master), or we'll need to close it. If there's no activity in about a month, we may close this. Let me know if you need help figuring out what to test / how. |
|
I looked and not sure that too much testing is necessary. I will add this in to #923, since I've re-worked the conditional there to be easier to read, so you'd have a conflict anyway.. |
|
D'oh, #834 had already addressed this anyway. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
…on blocks when other attributes aren't present (issue voxpupuli#741, replaces PR voxpupuli#596, h/t to vladpanainte) add $try_files as well
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
…on blocks when other attributes aren't present (issue voxpupuli#741, replaces PR voxpupuli#596, h/t to vladpanainte) add $try_files as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You should be able to create a location when $try_files is not empty