apt::key: puppetlabs-apt check now the full GPG fingerprints. #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 531ef9 of puppetlabs-apt, the gpg key (apt::key) is checked, and should use the long format. This value is validated with a regex enforcing it to only contain valid hexadecimal characters, be precisely 8 or 16 hexadecimal characters long and optionally prefixed with 0x for key IDs, or 40 hexadecimal characters long for key fingerprints. puppetlabs/puppetlabs-apt@f588f26
jfryman
added a commit
that referenced
this pull request
Mar 20, 2015
apt::key: puppetlabs-apt check now the full GPG fingerprints.
|
Excellent. Thanks! |
|
I'm still getting a warning with the 16 character gpg key:
The fix I put in was to add the 40 character key instead of the 16 character key. |
|
@errygg Ok. Great... misunderstood. Can you re-open and add tests then? |
|
erf… sorry for that… |
slm0n87
pushed a commit
to slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
apt::key: puppetlabs-apt check now the full GPG fingerprints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 531ef9 of puppetlabs-apt, the gpg key (apt::key) is
checked, and should use the long format.
This value is validated with a regex enforcing it to only contain valid
hexadecimal characters, be precisely 8 or 16 hexadecimal characters long
and optionally prefixed with 0x for key IDs, or 40 hexadecimal
characters long for key fingerprints.
puppetlabs/puppetlabs-apt@f588f26
This patch fixes the puppet warning below: