changed $::operatingsystemmajrelease to $::lsbmajdistrelease for Debian #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an as it does not exists in facter anymore
|
Yeah, I'm down with this. If you wanna PR for RH too, that would be most appreciated. |
jfryman
added a commit
that referenced
this pull request
Feb 5, 2015
…stemmajrelease changed $::operatingsystemmajrelease to $::lsbmajdistrelease for Debian
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
…eratingsystemmajrelease changed $::operatingsystemmajrelease to $::lsbmajdistrelease for Debian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact operatingsystemmajrelease does not exists in facter < 1.7 wich is installed by default on debian wheezy. That comes along with puppet 2.7.23 wich should be supported. The resolution is to use lsbmajdistrelease fact.
I only adopted the code for debian, just to here what you think. If you agree, I would also update the code for redhat etc.