Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine worker_processes validation #540

Closed
wants to merge 1 commit into from
Closed

refine worker_processes validation #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/config.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
) inherits ::nginx::params {

### Validations ###
if (!is_string($worker_processes)) and (!is_integer($worker_processes)) {
if (!is_string($worker_processes) or ($worker_processes != 'auto')) and (!is_integer($worker_processes)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Maybe remove the !is_string($worker_processes) in that case since it's redundant with the new condition you added.

fail('$worker_processes must be an integer or have value "auto".')
}
if (!is_integer($worker_connections)) {
Expand Down