Clean up package classes, allow installing mainline upstream packages #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 9, 2014 19:47
* Removed some tests that no longer apply and/or are redundant * Only set OS facts when testing OS-specific behaviors. This simplifies the facts that must be set in the specs and saves running the same tests several times when the results wouldn't differ by OS anyway.
Upstream doesn't provide a build of Nginx for Amazon Linux.
|
|
| default: { | ||
| fail("Module ${module_name} is not supported on ${::operatingsystem}") | ||
| } | ||
| package { $package_name: |
There was a problem hiding this comment.
Whoops, missed this during a rebase - I need to change this to package { 'nginx':
I'll fix tonight, so don't merge just yet.
There was a problem hiding this comment.
No worries. This was a big one, and I figured you'll merge when you're ready. Good 👀
This will provide broader OS compatibility without having to manually add support for specific OSes.
Those versions no longer supported by the Fedora Project.
Even if they're currently identical they may diverge in future.
i.e. upstream provides a package for it
The comments say this must be set on that OS so the failure makes that explicit.
The file wouldn't necessarily be at that location. According to Puppet it's installed in the first matching location: * Custom directory specified by the ‘/etc/yum.conf’ reposdir property * ‘/etc/yum/repos.d’ * ‘/etc/yum.repos.d’ * If none of these locations match, section will be created in ‘/etc/yum.conf’
* puppetlabs-apt does an APT update after every apt::source is added, so no need to do it again in this module. * Use the 'required_packages' feature of apt::source instead of ensure_resources
Required per the Passenger install guide
According to Passenger docs: "You should install nginx-extras even if you have already installed an Nginx package from the official Debian/Ubuntu repository. This is because the Nginx binary that our packages supply is compiled with the Passenger module."
|
I'll treasure that GIF forever :) I'll let this sit until the end of the weekend, barring any negative feedback or comments I'll merge then. |
3flex
added a commit
that referenced
this pull request
Dec 15, 2014
Clean up package classes, allow installing mainline upstream packages
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Clean up package classes, allow installing mainline upstream packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the way packages are handled by the module and cleans up the code significantly. No features are removed except with good reason, and it should be almost completely compatible with existing code (except for the
packageresource now always being called "nginx", and removing a couple of resources that were only for internal use).manage_repo => truewhen appropriate (i.e. upstream provides a package for it)$package_namenot set. The comments say this must be set on that OS so the failure makes that explicit.yumreporesource will do the right thing.apt::source.apt::source. This is required according to the Passenger documentation.