Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl_crl option support added #493

Closed
wants to merge 13 commits into from
Closed

ssl_crl option support added #493

wants to merge 13 commits into from

Conversation

teran
Copy link

@teran teran commented Oct 28, 2014

No description provided.

@3flex
Copy link
Contributor

3flex commented Oct 28, 2014

Hi @teran would you be able to add some tests for this new parameter?

Take a look at https://github.com/jfryman/puppet-nginx/blob/master/spec/defines/resource_vhost_spec.rb#L441-L446 for an example.

@teran
Copy link
Author

teran commented Oct 28, 2014

Hi @3flex sure, but a little bit later. Now I want simply run my code with uwsgi cherry-picked from PRs and these fixes. Then could sleek it all here.

Igor Shishkin added 4 commits October 28, 2014 23:20
Conflicts:
	templates/vhost/vhost_ssl_header.erb
Conflicts:
	templates/vhost/vhost_ssl_header.erb
@jfryman
Copy link
Contributor

jfryman commented Nov 22, 2014

Hi @teran!

Would still love to see this put in. Thanks!

@3flex 3flex mentioned this pull request Apr 10, 2015
5 tasks
@3flex 3flex added the enhancement New feature or request label Apr 15, 2015
@3flex 3flex mentioned this pull request May 6, 2015
@3flex 3flex closed this in #623 May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants