Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue 470 allow creation of location with only try_files #471

Closed
wants to merge 1 commit into from
Closed

issue 470 allow creation of location with only try_files #471

wants to merge 1 commit into from

Conversation

buckstr
Copy link

@buckstr buckstr commented Oct 7, 2014

This commit will fix #470.

@buckstr buckstr mentioned this pull request Oct 7, 2014
Closed
@3flex
Copy link
Contributor

3flex commented Apr 15, 2015

@buckstr the proposed PR won't allow you to create a location with only try_files.

As is, if you only set try_files and don't set proxy, location_alias, stub_status, fastcgi or www_root then the template vhost/locations/empty.erb will be rendered. This doesn't include try_files.

@3flex 3flex added the enhancement New feature or request label Apr 16, 2015
@wyardley
Copy link
Collaborator

wyardley commented Oct 6, 2016

Hi --
There's been no further activity on this since the 'needs Rebase' and 'needs tests' labels were set. If we don't have any further comments in the next month, this PR will be closed.

@wyardley
Copy link
Collaborator

Addressed in #834 already.

@wyardley wyardley closed this Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request needs-rebase needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot create location with only try_files defined
3 participants
@buckstr @3flex @wyardley