Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to detect the major release version for redhat/centos 7 #454

Merged
merged 1 commit into from
Sep 21, 2014

Conversation

francis826
Copy link

In Redhat/CentOS 7, lsbmajdistrelease was not being set due to a minimal install not having all the required dependencies for lsbmajdistrelease and falling back to the default $os_rel = 6. This caused the puppet install to fail due to the wrong yum repo being set. As you can see below the differences in the facter output:

[vagrant@localhost ~]$ facter kernel lsbmajdistrelease
kernel => Linux
lsbmajdistrelease => nil

compared to:

[vagrant@localhost ~]$ facter kernel operatingsystemmajrelease
kernel => Linux
operatingsystemmajrelease => 7

Puppet version: 3.7
CentOS version: CentOS Linux release 7.0.1406 (Core)

After these changes were made, I tested on CentOS 5.10, 6.5, and 7.0

This may be related to issue #445

I am fairly new to Puppet and apologize for any guidelines that weren't followed while submitting this pull request.

@3flex
Copy link
Contributor

3flex commented Sep 21, 2014

Thanks for fix! Makes perfect sense.

3flex added a commit that referenced this pull request Sep 21, 2014
Fix to detect the major release version for redhat/centos 7
@3flex 3flex merged commit f4ef310 into voxpupuli:master Sep 21, 2014
@3flex 3flex mentioned this pull request Sep 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants