Add OpenBSD support.

[buzzdeee]

The title says it, support for OpenBSD is added, tested on OpenBSD 5.6-current.

[3flex]

Waiting on #423

[jfryman]

Go ahead and merge things. I went to work on #423 last weekend, and the
change from the previous week made it difficult to track all that's
changing.

What I'll end up doing tomorrow is starting over with master, and
doing a few things slightly differently based on our conversation there.
Consider #423 a Mikado. 😁

Matthew Haughton wrote:

Waiting on #423 #423

—
Reply to this email directly or view it on GitHub
#448 (comment).

[3flex]

hi @buzzdeee can you tell me what Facter reports for osfamily and operatingsystem on OpenBSD? Thanks!

[buzzdeee]

Sure I can:
facter | grep -e osfamil -e operatingsys
operatingsystem => OpenBSD
operatingsystemmajrelease => 5
operatingsystemrelease => 5.6-current
osfamily => OpenBSD

[frenkel]

This pull requests works good on -stable. Should it be modified to use Hiera, just like master?

[3flex]

Hi @frenkel that would be ideal. Everything looks good, just put the changes flagged for params.pp into an OpenBSD.yaml file in data/osfamily.

[3flex]

Or @buzzdeee if you want to run with this using this original PR!

[buzzdeee]

There are merge conflicts already. With my still limited Git skills, I might mess up this merge request, and I don't really want that.
The easiest way for me would be:

You merge this, and I create a new merge request, containing the hiera related changes. I would like to also include the support for package flavors (something specific to OpenBSD ports/packages), since the nginx port comes with flavors (lua, ruby, etc.).

If you prefer, I can try to just add this hiera file to the version I currently have, in the hope not to break anything ;)

[zachfi]

How can I help this along?

[frenkel]

Try to get master to load on OpenBSD without Puppet errors? :) #484

[3flex]

@jfryman decided to pull puppet-module-data out (#501), so once that's done we'll go back to a variant of this original PR. When 501 is merged we can rebase this and put the OS specific stuff into params.pp.

[frenkel]

Didn't know, thanks for the heads up!

[jfryman]

@frenkel @xaque208 It seems that weekends are the only time I have cycles to work on this... :. Will merge #501 this weekend, and then I'd love to circle about and get this merged in.

[frenkel]

No problem, your work is much appreciated, I use it on a lot of Linux servers as well :)
After you merge #501 I'll try to test this on OpenBSD some more.

[jfryman]

Hi @frastel!

I just merged #501. Wanna take another check?

[frenkel]

Thanks @jfryman. I couldn't get this pull request to rebase without a load of conflicts, so I manually added the needed changes in a seperate pull-request: #507
Maybe we should close this one and discuss further (if needed) in that one?