Removed proxy_cache_valid as default when using proxy_cache option #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add tests for this changed behavior? You can add it around https://github.com/jfryman/puppet-nginx/blob/master/spec/defines/resource_location_spec.rb#L533, use the existing tests as a template. Once this is done I'll merge. |
Added some tests also
pablokbs
force-pushed
the
proxy_cache_valid_fix
branch
from
f74d168 to
ac1e9b7
Compare
|
Added tests and rebased, please check. |
3flex
added a commit
that referenced
this pull request
Sep 3, 2014
Removed proxy_cache_valid as default when using proxy_cache option
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Removed proxy_cache_valid as default when using proxy_cache option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
If you specify the option proxy_cache, the module automatically add proxy_cache_valid with "false" as an argument, this fails. And this option is not mandatory when using proxy_cache, so I made it optional.
Hope is OK