Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added add_header to nginx::resource::location #402

Closed
wants to merge 1 commit into from

Conversation

chaosmail
Copy link
Contributor

I made add_header available also in location, and added a test for add_header in vhosts

@3flex 3flex added the enhancement New feature or request label Apr 16, 2015
@cyberious
Copy link

Any possibility of writing acceptance tests as well for this?

@chaosmail
Copy link
Contributor Author

Its been 2 years i submitted this PR :) think this is slightly outdated

@wyardley
Copy link
Collaborator

wyardley commented Oct 6, 2016

@chaosmail @cyberious: Does anyone want to update this and resolve the conflicts? As @chaosmail says, the PR is pretty out of date now.

If there are no more changes or comments in the next month, we may close this for inactivity.

@wyardley
Copy link
Collaborator

There was also some discussion in #899 about supporting the 'always' directive. I'm not sure how that would be implemented, would probably have to be a hash with an option of having an array as the hash value. For now, I'm going to close this out (I think people can use the location append / prepend features if necessary), feel free to open a new PR if someone wants to implement this. I think it would be smart to do it as above, though it would probably be a good idea to add the same functionality backwards (in a backwards compatible way) to vhost as well.

@wyardley wyardley closed this Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants