Correct validation of {proxy,fastcgi}_cache_levels #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow any combination of 1 and 2 in these formats: X, X:X, and X:X:X, e.g.: "2", "2:2", "1:1:2". The old validation failed if it wasn't an integer which didn't allow these formats.
|
@jfryman my other PRs don't add features or fix any bugs but this one should be merged unless there's anything missing? Do you want additional tests? |
|
Nah, this is ok. I'm really just holding off until this Sunday, where I'm going to be spending the day on this module, PRs, and a ton of outstanding cleanup. |
3flex
added a commit
that referenced
this pull request
Sep 3, 2014
Correct validation of {proxy,fastcgi}_cache_levels
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
…s-validation
Correct validation of {proxy,fastcgi}_cache_levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow any combination of 1 and 2 in these formats: X, X:X, and X:X:X, e.g.: "2", "2:2", "1:1:2". The old validation failed if it wasn't an integer which didn't allow these formats.
Fixes #294