Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed testing variables in init.pp #371

Merged
merged 1 commit into from
Jul 2, 2014
Merged

Changed testing variables in init.pp #371

merged 1 commit into from
Jul 2, 2014

Conversation

mr-tron
Copy link
Contributor

@mr-tron mr-tron commented Jul 2, 2014

Bad logic for type validate.

Bad logic for type validate.
@jfryman
Copy link
Contributor

jfryman commented Jul 2, 2014

Well, I'm not sure what this is for. The ability to specify either an array or a hash was added in #369.

@mr-tron
Copy link
Contributor Author

mr-tron commented Jul 2, 2014

Now if variable is hash (for example), this condition return fail('$http_cfg_append must be either a hash or array'), because:

  1. http_cfg_append = {'dfffd'=>'dsfdsf'}
    2)is_hash($http_cfg_append) = true
    is_array($http_cfg_append) = false
    3)!is_hash($http_cfg_append) = false
    !is_array($http_cfg_append) = true
  2. !is_hash($http_cfg_append) or !is_array($http_cfg_append)= true
    variant of fix: !is_hash($http_cfg_append) and !is_array($http_cfg_append)

@Briareos
Copy link

Briareos commented Jul 2, 2014

+1
The module is currently broken, as $http_cfg_append directive can't accept any value.

jfryman pushed a commit that referenced this pull request Jul 2, 2014
Changed testing variables in init.pp
@jfryman jfryman merged commit 91e92e7 into voxpupuli:master Jul 2, 2014
@jfryman
Copy link
Contributor

jfryman commented Jul 2, 2014

Well, let's 🔧 that. Thanks. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants