Always set the root parameter in nginx::vhost resources.

[joshuaspence]

The root parameter should always be set to $www_root, even if use_default_location is set to true. This is a lot easier than the alternative of explicitly specifying www_root in all location blocks.

[janorn]

I think this PR will change the behavior. If you want to achieve this you should only specify this parameter:
use_default_location => false

Then you will not need to specify www_root for all location blocks. You will however need to specify a "/" location.
This functionality was added in #145

[janorn]

There are cases when you don't want to have root set on the vhost level but only on the location level.

[janorn]

I guess a possible way around this would be to add a new parameter www_root_default. And if either this is set or use_default_location is false add www_root.

[zachfi]

-1 on this PR.

[jfryman]

Can you give me a use case where #145 would not cover you?

[joshuaspence]

Sorry, I don't see how #145 is related?

To me, this change makes sense. It could at least be toggled with an optional parameter. But it seems counter-intuitive that specifying use_default_location would disable the root directive for the parent block.